summaryrefslogtreecommitdiff
path: root/libpanto/src/provider_openai_chat.zig
blob: 2343ac1403e70f892df0a985b25872645eba2469 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
//! OpenAI Chat Completions streaming provider.
//!
//! Wire format reference: https://platform.openai.com/docs/api-reference/chat/streaming
//!
//! Responsibilities:
//!   - Convert `Conversation` → request JSON (delegated to openai_chat_json.zig)
//!   - POST to `{base_url}/chat/completions` with `stream: true`
//!   - Read the chunked body, feed bytes through SSEParser
//!   - Parse each event payload, drive the block boundary state machine,
//!     and emit Receiver callbacks
//!   - Assemble the final Message and emit onMessageComplete

const std = @import("std");
const Allocator = std.mem.Allocator;
const Io = std.Io;
const http = std.http;
const Uri = std.Uri;

const conversation = @import("conversation.zig");
const provider_mod = @import("provider.zig");
const sse_mod = @import("sse.zig");
const json_mod = @import("openai_chat_json.zig");
const config_mod = @import("config.zig");

/// Active streaming block type tracked by the state machine. Mirrors the
/// `ContentBlock` union variants but adds `.none` for "no block open yet".
const ActiveBlock = enum { none, text, thinking, tool_use };

pub const OpenAIChatProvider = struct {
    allocator: Allocator,
    io: Io,
    config: config_mod.OpenAIChatConfig,
    http_client: http.Client,

    pub fn init(allocator: Allocator, io: Io, cfg: config_mod.OpenAIChatConfig) OpenAIChatProvider {
        return .{
            .allocator = allocator,
            .io = io,
            .config = cfg,
            .http_client = .{ .allocator = allocator, .io = io },
        };
    }

    pub fn deinit(self: *OpenAIChatProvider) void {
        self.http_client.deinit();
    }

    /// Return a `Provider` interface bound to this concrete provider.
    pub fn provider(self: *OpenAIChatProvider) provider_mod.Provider {
        return .{ .ptr = self, .vtable = &vtable };
    }

    const vtable: provider_mod.ProviderVTable = .{
        .streamStep = vtableStreamStep,
        .deinit = vtableDeinit,
    };

    fn vtableStreamStep(
        ptr: *anyopaque,
        conv: *conversation.Conversation,
        tools: *const provider_mod.ToolRegistry,
        receiver: *provider_mod.Receiver,
    ) anyerror!void {
        const self: *OpenAIChatProvider = @ptrCast(@alignCast(ptr));
        return self.streamStep(conv, tools, receiver);
    }

    /// Called via the `Provider` interface. Tears down the impl AND frees
    /// its heap allocation, since `Provider.init` is the one that allocated
    /// it. Direct stack-allocated users (tests, embedders) call `deinit`
    /// themselves and never hit this path.
    fn vtableDeinit(ptr: *anyopaque) void {
        const self: *OpenAIChatProvider = @ptrCast(@alignCast(ptr));
        const allocator = self.allocator;
        self.deinit();
        allocator.destroy(self);
    }

    pub fn streamStep(
        self: *OpenAIChatProvider,
        conv: *conversation.Conversation,
        tools: *const provider_mod.ToolRegistry,
        receiver: *provider_mod.Receiver,
    ) !void {
        // Outer wrapper guarantees `onError` is called exactly once if
        // anything fails — whether the receiver, the HTTP transport, or the
        // SSE/JSON parsers. The inner `streamStepInner` does the real work.
        self.streamStepInner(conv, tools, receiver) catch |err| {
            receiver.onError(err);
            return err;
        };
    }

    fn streamStepInner(
        self: *OpenAIChatProvider,
        conv: *conversation.Conversation,
        tools: *const provider_mod.ToolRegistry,
        receiver: *provider_mod.Receiver,
    ) !void {
        // Build URL: "{base_url}/chat/completions"
        const url = try std.fmt.allocPrint(
            self.allocator,
            "{s}/chat/completions",
            .{self.config.base_url},
        );
        defer self.allocator.free(url);

        const uri = try Uri.parse(url);

        // Build the request body.
        const body = try json_mod.serializeRequest(self.allocator, &self.config, conv, tools);
        defer self.allocator.free(body);

        // Auth header
        const auth_value = try std.fmt.allocPrint(
            self.allocator,
            "Bearer {s}",
            .{self.config.api_key},
        );
        defer self.allocator.free(auth_value);

        const extra_headers = [_]http.Header{
            .{ .name = "content-type", .value = "application/json" },
            .{ .name = "accept", .value = "text/event-stream" },
            .{ .name = "authorization", .value = auth_value },
        };

        // Open the request. We can't use `fetch()` because it buffers the
        // response; we want to stream the body as it arrives.
        var req = try self.http_client.request(.POST, uri, .{
            .extra_headers = &extra_headers,
            // Disable compression: gzip buffers small SSE frames, defeating
            // the streaming property we paid for `stream: true` to get.
            .headers = .{ .accept_encoding = .{ .override = "identity" } },
            .keep_alive = false,
            .redirect_behavior = .not_allowed,
        });
        defer req.deinit();

        req.transfer_encoding = .{ .content_length = body.len };

        var send_buf: [4096]u8 = undefined;
        var bw = try req.sendBodyUnflushed(&send_buf);
        try bw.writer.writeAll(body);
        try bw.end();
        try req.connection.?.flush();

        // Receive response headers.
        var redirect_buf: [1024]u8 = undefined;
        var response = try req.receiveHead(&redirect_buf);

        if (@intFromEnum(response.head.status) >= 400) {
            // Drain body for diagnostics.
            var transfer_buf: [4096]u8 = undefined;
            const body_reader = response.reader(&transfer_buf);
            var err_buf: std.ArrayList(u8) = .empty;
            defer err_buf.deinit(self.allocator);
            var tmp: [1024]u8 = undefined;
            while (true) {
                const n = body_reader.readSliceShort(&tmp) catch break;
                if (n == 0) break;
                try err_buf.appendSlice(self.allocator, tmp[0..n]);
                if (err_buf.items.len > 16 * 1024) break;
            }
            std.log.err("openai_chat HTTP {d}: {s}", .{
                @intFromEnum(response.head.status),
                err_buf.items,
            });
            return error.HttpError;
        }

        // Stream the body through the SSE parser and event handler.
        var transfer_buf: [4096]u8 = undefined;
        const body_reader = response.reader(&transfer_buf);

        var parser = sse_mod.SSEParser.init(self.allocator);
        defer parser.deinit();

        var state: StreamState = .init(self.allocator);
        defer state.deinit();

        // Use `readVec` so we return to the event loop as soon as *any*
        // bytes arrive, rather than waiting for the buffer to fill.
        // `readSliceShort` blocks until EOF or full, which defeats streaming.
        //
        // Per `std.Io.Reader.readVec` docs: a return value of 0 does NOT
        // signal end-of-stream — it just means no new bytes were available
        // this call, and the caller should try again. EOF is reported only
        // via `error.EndOfStream`. Breaking on `n == 0` truncates the
        // response and silently cuts off mid-stream.
        var chunk: [4096]u8 = undefined;
        var vecs: [1][]u8 = .{&chunk};
        while (true) {
            const n = body_reader.readVec(&vecs) catch |err| switch (err) {
                error.EndOfStream => break,
                else => return err,
            };
            if (n == 0) continue;

            const events = try parser.feed(chunk[0..n]);
            defer parser.freeEvents(events);

            for (events) |ev_payload| {
                std.log.debug("openai_chat <= {s}", .{ev_payload});
                if (std.mem.eql(u8, ev_payload, "[DONE]")) {
                    try state.finalize(receiver, conv);
                    return;
                }
                try handleEvent(self.allocator, ev_payload, &state, receiver);
                if (state.end_of_stream) {
                    try state.finalize(receiver, conv);
                    return;
                }
            }
        }

        // Stream ended without [DONE] or finish_reason. Finalize anyway.
        try state.finalize(receiver, conv);
    }
};

/// State maintained across the streaming response: which block is currently
/// being assembled, accumulated content, and the assistant message being
/// built up for the final `onMessageComplete` callback.
///
/// Text and thinking blocks are mutually exclusive at the active position
/// (openai_chat streams one at a time and we infer transitions). ToolUse
/// blocks live in a side map keyed by the wire's per-call `index`; multiple
/// tool calls can stream concurrently in the same response. At finalize
/// time, tool_use blocks are appended after the text/thinking blocks in
/// ascending wire-index order.
const StreamState = struct {
    allocator: Allocator,
    started: bool = false,
    /// Set when the wire stream signals end-of-turn (finish_reason or [DONE]).
    /// Tells the outer read loop to stop pulling more events.
    end_of_stream: bool = false,
    /// Set once `finalize` has run, to make it idempotent.
    finalized: bool = false,
    active: ActiveBlock = .none,
    /// Block index reported to the receiver. Increments per block boundary.
    /// Tool-use blocks reuse a per-tool-call counter (`tool_block_index`
    /// inside `ToolUseInProgress`) for their `onContentDelta` reports.
    block_index: usize = 0,

    /// Buffer for the currently-streaming text/thinking block. Owned by
    /// this state until the block is completed, at which point ownership
    /// transfers to the assembled Message.
    current_buf: conversation.TextualBlock = .empty,

    /// Assembled non-tool-use blocks for the final message, in stream order.
    blocks: std.ArrayList(conversation.ContentBlock) = .empty,

    /// In-progress tool_use blocks keyed by wire index.
    tool_uses: std.AutoHashMap(usize, ToolUseInProgress),

    const ToolUseInProgress = struct {
        /// Block index emitted to the receiver for this tool call's
        /// onBlockStart / onContentDelta / onBlockComplete callbacks.
        block_index: usize,
        /// id/name are buffered as TextualBlocks because lenient providers
        /// (OpenRouter passthroughs, some self-hosted backends) may stream
        /// either field as fragments across multiple deltas. OpenAI itself
        /// sends them whole on the first delta, but the structural cost of
        /// supporting fragments is small and worth the robustness.
        id_buf: conversation.TextualBlock = .empty,
        name_buf: conversation.TextualBlock = .empty,
        arguments: conversation.TextualBlock = .empty,
        /// We defer `onBlockStart` until either the first argument fragment
        /// arrives or finalize runs — whichever happens first — because by
        /// then identity is almost certainly complete and we can pass a
        /// well-formed `BlockMeta` to the receiver.
        started: bool = false,

        fn deinit(self: *ToolUseInProgress, allocator: Allocator) void {
            self.id_buf.deinit(allocator);
            self.name_buf.deinit(allocator);
            self.arguments.deinit(allocator);
        }
    };

    fn init(allocator: Allocator) StreamState {
        return .{
            .allocator = allocator,
            .tool_uses = std.AutoHashMap(usize, ToolUseInProgress).init(allocator),
        };
    }

    fn deinit(self: *StreamState) void {
        self.current_buf.deinit(self.allocator);
        for (self.blocks.items) |*b| b.deinit(self.allocator);
        self.blocks.deinit(self.allocator);
        var it = self.tool_uses.iterator();
        while (it.next()) |entry| entry.value_ptr.deinit(self.allocator);
        self.tool_uses.deinit();
    }

    /// Close the active text/thinking block (if any) and emit
    /// onBlockComplete. Ownership of `current_buf` transfers into the
    /// appended block.
    fn closeActive(self: *StreamState, receiver: *provider_mod.Receiver) !void {
        if (self.active == .none) return;

        const block: conversation.ContentBlock = switch (self.active) {
            .text => .{ .Text = self.current_buf },
            .thinking => .{ .Thinking = .{ .text = self.current_buf } },
            .tool_use, .none => unreachable,
        };
        self.current_buf = .empty;

        try self.blocks.append(self.allocator, block);
        try receiver.onBlockComplete(self.block_index, self.blocks.items[self.blocks.items.len - 1]);

        self.active = .none;
    }

    /// Open a new text/thinking block, possibly closing a prior one.
    fn openBlock(
        self: *StreamState,
        new_active: ActiveBlock,
        receiver: *provider_mod.Receiver,
    ) !void {
        std.debug.assert(new_active == .text or new_active == .thinking);
        if (self.active == new_active) return;
        if (self.active != .none) {
            try self.closeActive(receiver);
            self.block_index += 1;
        }
        self.active = new_active;
        const block_type: provider_mod.ContentBlockType = switch (new_active) {
            .text => .Text,
            .thinking => .Thinking,
            .tool_use, .none => unreachable,
        };
        try receiver.onBlockStart(block_type, self.block_index, null);
    }

    fn appendDelta(
        self: *StreamState,
        receiver: *provider_mod.Receiver,
        delta: []const u8,
    ) !void {
        try self.current_buf.appendSlice(self.allocator, delta);
        try receiver.onContentDelta(self.block_index, delta);
    }

    /// Apply one streaming tool_call delta. Allocates a new
    /// `ToolUseInProgress` slot on first sight of each wire index.
    fn applyToolCallDelta(
        self: *StreamState,
        receiver: *provider_mod.Receiver,
        d: json_mod.ToolCallDelta,
    ) !void {
        const gop = try self.tool_uses.getOrPut(d.index);
        if (!gop.found_existing) {
            // First sight: close any open text/thinking block so the
            // tool_use gets its own block_index.
            if (self.active != .none) {
                try self.closeActive(receiver);
                self.block_index += 1;
            }
            gop.value_ptr.* = .{ .block_index = self.block_index };
            self.block_index += 1;
        }
        const tu = gop.value_ptr;

        // Append identity fragments. Most providers send id+name whole on
        // the first delta and never repeat them, but appending is the only
        // correct behavior across the full range of OpenAI-compatible
        // backends — some chunk these strings.
        if (d.id) |s| try tu.id_buf.appendSlice(self.allocator, s);
        if (d.name) |s| try tu.name_buf.appendSlice(self.allocator, s);

        // Defer `onBlockStart` until we have a complete identity. The
        // first argument fragment is our signal that the provider is done
        // emitting identity for this index. If finalize runs first (i.e.
        // a tool call with no arguments), we emit it there.
        if (d.arguments) |a| {
            try self.emitStartIfNeeded(receiver, tu);
            try tu.arguments.appendSlice(self.allocator, a);
            try receiver.onContentDelta(tu.block_index, a);
        }
    }

    /// Emit `onBlockStart(.ToolUse, ...)` once per in-progress tool use,
    /// passing whatever identity we have. Callers must invoke this before
    /// the first `onContentDelta` or `onBlockComplete` for the block.
    fn emitStartIfNeeded(
        self: *StreamState,
        receiver: *provider_mod.Receiver,
        tu: *ToolUseInProgress,
    ) !void {
        _ = self;
        if (tu.started) return;
        tu.started = true;
        const meta: ?provider_mod.BlockMeta = if (tu.id_buf.items.len > 0 or tu.name_buf.items.len > 0)
            .{
                .tool_id = if (tu.id_buf.items.len > 0) tu.id_buf.items else null,
                .tool_name = if (tu.name_buf.items.len > 0) tu.name_buf.items else null,
            }
        else
            null;
        try receiver.onBlockStart(.ToolUse, tu.block_index, meta);
    }

    /// End the stream: close any open text/thinking block, finalize all
    /// in-flight tool_use blocks (in ascending wire-index order), then
    /// commit the assembled assistant Message to the conversation.
    fn finalize(
        self: *StreamState,
        receiver: *provider_mod.Receiver,
        conv: *conversation.Conversation,
    ) !void {
        if (self.finalized) return;
        self.finalized = true;

        try self.closeActive(receiver);

        // Collect tool_use indices in ascending order for deterministic
        // ordering in the final message.
        var indices: std.ArrayList(usize) = .empty;
        defer indices.deinit(self.allocator);
        var it = self.tool_uses.iterator();
        while (it.next()) |entry| try indices.append(self.allocator, entry.key_ptr.*);
        std.mem.sort(usize, indices.items, {}, std.sort.asc(usize));

        for (indices.items) |idx| {
            const tu_ptr = self.tool_uses.getPtr(idx).?;
            // Drop entries lacking id or name. The stream ended before
            // the provider sent enough to identify which tool was being
            // called — there's nothing we can dispatch. We log enough
            // detail to make this diagnosable; the agent will surface the
            // resulting empty assistant message as EmptyAssistantResponse.
            if (tu_ptr.id_buf.items.len == 0 or tu_ptr.name_buf.items.len == 0) {
                if (!@import("builtin").is_test) {
                    std.log.err(
                        "openai_chat: dropping incomplete tool_use at wire index {d}: id={d} bytes, name=\"{s}\", args={d} bytes",
                        .{
                            idx,
                            tu_ptr.id_buf.items.len,
                            tu_ptr.name_buf.items,
                            tu_ptr.arguments.items.len,
                        },
                    );
                }
                tu_ptr.deinit(self.allocator);
                continue;
            }

            // If no arguments ever arrived, we haven't emitted onBlockStart
            // yet — do it now so the receiver sees a balanced start/complete.
            try self.emitStartIfNeeded(receiver, tu_ptr);

            const block_index = tu_ptr.block_index;
            const id_owned = try tu_ptr.id_buf.toOwnedSlice(self.allocator);
            const name_owned = try tu_ptr.name_buf.toOwnedSlice(self.allocator);
            const block: conversation.ContentBlock = .{ .ToolUse = .{
                .id = id_owned,
                .name = name_owned,
                .input = tu_ptr.arguments,
            } };
            // Ownership has moved into `block`; clear the in-progress slot.
            tu_ptr.arguments = .empty;

            try self.blocks.append(self.allocator, block);
            try receiver.onBlockComplete(
                block_index,
                self.blocks.items[self.blocks.items.len - 1],
            );
        }

        // Move blocks into a fresh conversation message.
        const moved_blocks = try self.blocks.toOwnedSlice(self.allocator);
        defer self.allocator.free(moved_blocks);

        try conv.addAssistantMessage(moved_blocks);

        const msg = conv.messages.items[conv.messages.items.len - 1];
        try receiver.onMessageComplete(msg);
    }
};

fn handleEvent(
    allocator: Allocator,
    payload: []const u8,
    state: *StreamState,
    receiver: *provider_mod.Receiver,
) !void {
    var parsed = try json_mod.parseStreamEvent(allocator, payload);
    defer parsed.deinit();
    const d = parsed.delta;

    // Mid-stream provider error: some OpenAI-compatible endpoints (and
    // OpenAI itself on rare transient failures) return HTTP 200 with an
    // error embedded in the SSE stream. Treat the turn as failed.
    if (d.error_message != null or d.error_type != null) {
        if (!@import("builtin").is_test) {
            std.log.err("openai_chat stream error: {?s}: {?s}", .{
                d.error_type, d.error_message,
            });
        }
        return error.StreamError;
    }

    if (!state.started and d.role != null) {
        state.started = true;
        try receiver.onMessageStart(.assistant);
    }

    if (d.reasoning_content) |rc| {
        if (!state.started) {
            state.started = true;
            try receiver.onMessageStart(.assistant);
        }
        try state.openBlock(.thinking, receiver);
        try state.appendDelta(receiver, rc);
    }

    if (d.content) |c| {
        if (!state.started) {
            state.started = true;
            try receiver.onMessageStart(.assistant);
        }
        try state.openBlock(.text, receiver);
        try state.appendDelta(receiver, c);
    }

    if (d.tool_calls.len > 0) {
        if (!state.started) {
            state.started = true;
            try receiver.onMessageStart(.assistant);
        }
        for (d.tool_calls) |tc| try state.applyToolCallDelta(receiver, tc);
    }

    if (d.finish_reason) |_| {
        state.end_of_stream = true;
    }
}

// -----------------------------------------------------------------------------
// Tests
// -----------------------------------------------------------------------------

const testing = std.testing;

/// A no-op Receiver that drops every callback. Useful when the test cares
/// about post-stream conversation state rather than callback observability.
const NoopReceiver = struct {
    fn make() provider_mod.Receiver {
        return .{ .ptr = @constCast(@ptrCast(&dummy)), .vtable = &vt };
    }
    var dummy: u8 = 0;
    const vt: provider_mod.ReceiverVTable = .{
        .onMessageStart = noopMsgStart,
        .onBlockStart = noopBlockStart,
        .onContentDelta = noopDelta,
        .onBlockComplete = noopBlockComplete,
        .onMessageComplete = noopMsgComplete,
        .onError = noopErr,
    };
    fn noopMsgStart(_: *anyopaque, _: conversation.MessageRole) anyerror!void {}
    fn noopBlockStart(_: *anyopaque, _: provider_mod.ContentBlockType, _: usize, _: ?provider_mod.BlockMeta) anyerror!void {}
    fn noopDelta(_: *anyopaque, _: usize, _: []const u8) anyerror!void {}
    fn noopBlockComplete(_: *anyopaque, _: usize, _: conversation.ContentBlock) anyerror!void {}
    fn noopMsgComplete(_: *anyopaque, _: conversation.Message) anyerror!void {}
    fn noopErr(_: *anyopaque, _: anyerror) void {}
};

/// Feed a sequence of SSE event payloads through the state machine as if
/// they had been delivered by the wire, finalizing into `conv`.
fn runStreamedTurn(
    allocator: Allocator,
    conv: *conversation.Conversation,
    receiver: *provider_mod.Receiver,
    events: []const []const u8,
) !void {
    var state: StreamState = .init(allocator);
    defer state.deinit();

    for (events) |payload| {
        if (std.mem.eql(u8, payload, "[DONE]")) break;
        try handleEvent(allocator, payload, &state, receiver);
        if (state.end_of_stream) break;
    }
    try state.finalize(receiver, conv);
}

test "two streamed turns persist assistant replies in the conversation" {
    // Regression test for the bug where `finish_reason` arrived before
    // `[DONE]` and `finalize` early-returned without appending the assistant
    // message, so follow-up turns were sent without prior responses.

    const allocator = testing.allocator;

    var conv = conversation.Conversation.init(allocator);
    defer conv.deinit();

    try conv.addSystemMessage("You are a helpful assistant.");
    try conv.addUserMessage("hello!");

    var recv = NoopReceiver.make();

    const turn1 = [_][]const u8{
        \\{"choices":[{"delta":{"role":"assistant"}}]}
        ,
        \\{"choices":[{"delta":{"content":"Hello! "}}]}
        ,
        \\{"choices":[{"delta":{"content":"How can I help you today?"}}]}
        ,
        \\{"choices":[{"delta":{},"finish_reason":"stop"}]}
        ,
        "[DONE]",
    };
    try runStreamedTurn(allocator, &conv, &recv, &turn1);

    try testing.expectEqual(@as(usize, 3), conv.messages.items.len);
    try testing.expectEqual(conversation.MessageRole.assistant, conv.messages.items[2].role);
    try testing.expectEqualStrings(
        "Hello! How can I help you today?",
        conv.messages.items[2].content.items[0].Text.items,
    );

    // Second user turn: the assistant must still see its prior response.
    try conv.addUserMessage("how did you respond to my greeting just now?");

    const turn2 = [_][]const u8{
        \\{"choices":[{"delta":{"role":"assistant"}}]}
        ,
        \\{"choices":[{"delta":{"content":"I replied: \"Hello! How can I help you today?\""}}]}
        ,
        \\{"choices":[{"delta":{},"finish_reason":"stop"}]}
        ,
        "[DONE]",
    };
    try runStreamedTurn(allocator, &conv, &recv, &turn2);

    // System + user + assistant + user + assistant = 5 messages.
    try testing.expectEqual(@as(usize, 5), conv.messages.items.len);
    try testing.expectEqual(conversation.MessageRole.assistant, conv.messages.items[4].role);
    try testing.expectEqualStrings(
        "I replied: \"Hello! How can I help you today?\"",
        conv.messages.items[4].content.items[0].Text.items,
    );
}

test "fragmented tool_call id and name are reassembled" {
    // Lenient OpenAI-compatible providers occasionally split `id` and
    // `function.name` across multiple deltas instead of sending them whole
    // on the first chunk. Verify the state machine appends both correctly
    // and emits a complete identity to the receiver.
    const allocator = testing.allocator;

    var conv = conversation.Conversation.init(allocator);
    defer conv.deinit();
    try conv.addUserMessage("call something");

    var recv = NoopReceiver.make();

    const events = [_][]const u8{
        \\{"choices":[{"delta":{"role":"assistant"}}]}
        ,
        \\{"choices":[{"delta":{"tool_calls":[{"index":0,"id":"call_","type":"function","function":{"name":"pi"}}]}}]}
        ,
        \\{"choices":[{"delta":{"tool_calls":[{"index":0,"id":"xyz","function":{"name":"ng"}}]}}]}
        ,
        \\{"choices":[{"delta":{"tool_calls":[{"index":0,"function":{"arguments":"{\"host\":\"a.com\"}"}}]}}]}
        ,
        \\{"choices":[{"delta":{},"finish_reason":"tool_calls"}]}
        ,
        "[DONE]",
    };

    try runStreamedTurn(allocator, &conv, &recv, &events);

    const asst = conv.messages.items[1];
    try testing.expectEqual(@as(usize, 1), asst.content.items.len);
    const tu = asst.content.items[0].ToolUse;
    try testing.expectEqualStrings("call_xyz", tu.id);
    try testing.expectEqualStrings("ping", tu.name);
    try testing.expectEqualStrings("{\"host\":\"a.com\"}", tu.input.items);
}

test "tool_call with no arguments still finalizes a well-formed ToolUse" {
    // Some providers may emit a tool call with no arguments at all (e.g. a
    // zero-arg tool). The state machine should still emit onBlockStart
    // exactly once at finalize time and produce a ToolUse with empty input.
    const allocator = testing.allocator;

    var conv = conversation.Conversation.init(allocator);
    defer conv.deinit();
    try conv.addUserMessage("ring it");

    var recv = NoopReceiver.make();

    const events = [_][]const u8{
        \\{"choices":[{"delta":{"role":"assistant"}}]}
        ,
        \\{"choices":[{"delta":{"tool_calls":[{"index":0,"id":"c1","type":"function","function":{"name":"ring"}}]}}]}
        ,
        \\{"choices":[{"delta":{},"finish_reason":"tool_calls"}]}
        ,
        "[DONE]",
    };

    try runStreamedTurn(allocator, &conv, &recv, &events);

    const asst = conv.messages.items[1];
    try testing.expectEqual(@as(usize, 1), asst.content.items.len);
    const tu = asst.content.items[0].ToolUse;
    try testing.expectEqualStrings("c1", tu.id);
    try testing.expectEqualStrings("ring", tu.name);
    try testing.expectEqual(@as(usize, 0), tu.input.items.len);
}