summaryrefslogtreecommitdiff
path: root/agent/tools/edit.lua
blob: 2fa34689416e9b1d7578d1275f4f61e1f3ca6b98 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
-- Apply a batch of exact-text replacements to a file. Keep the tool
-- description terse; the rules are enforced here rather than re-stated
-- in prose, with the rejection message naming exactly which rule each
-- entry tripped so the model can self-correct on the next call.
--
-- Rejection rules (atomic — any failure rejects the whole call):
--   1. Each `old` must occur exactly once in the original file.
--   2. `old` may not be the empty string.
--   3. Resolved ranges of `old` matches must not overlap.
-- All matches are evaluated against the original file, not
-- progressively against the result of earlier entries.

local std = require("_std")

local tool = {
    name = "std.edit",
    description = "Apply exact-text replacements to a file. Each entry's `old` must match exactly once in the original file (not progressively). Edits whose ranges overlap, match zero times, or match multiple times reject the entire call — no partial edits, file untouched. Keep `old` minimal but unique; widen with surrounding context if needed.",
    schema = {
        type = "object",
        properties = {
            path = { type = "string", description = "Path to the file (relative or absolute)." },
            edits = {
                type = "array",
                description = "Replacements applied atomically.",
                minItems = 1,
                items = {
                    type = "object",
                    properties = {
                        old = { type = "string", description = "Exact substring to find; must appear exactly once." },
                        new = { type = "string", description = "Replacement text (may be empty to delete)." },
                    },
                    required = { "old", "new" },
                },
            },
        },
        required = { "path", "edits" },
    },
}

-- Read an entire file into a string. Returns (content, nil) or
-- (nil, err). EOF on `fs_read` is the empty string, not nil.
local function read_all(path)
    local err, fd = std.fs_open(path, "r", 0)
    if not fd then return nil, err end
    local serr, st = std.fs_fstat(fd)
    if not st then std.fs_close(fd); return nil, serr end
    local parts, offset = {}, 0
    while true do
        local rerr, data = std.fs_read(fd, 64 * 1024, offset)
        if rerr then std.fs_close(fd); return nil, rerr end
        if data == nil or #data == 0 then break end
        parts[#parts + 1] = data
        offset = offset + #data
    end
    std.fs_close(fd)
    return table.concat(parts), nil
end

-- Overwrite a file with `content` (O_WRONLY|O_CREAT|O_TRUNC, 0644).
-- Returns (true, nil) or (nil, err).
local function write_all(path, content)
    local err, fd = std.fs_open(path, "w", tonumber("644", 8))
    if not fd then return nil, err end
    -- A single `fs_write` may short-write; loop until all bytes land.
    local offset = 0
    while offset < #content do
        local werr, n = std.fs_write(fd, content:sub(offset + 1), offset)
        if not n then std.fs_close(fd); return nil, werr end
        offset = offset + n
    end
    -- Empty content still needs the truncate that O_TRUNC gave us.
    std.fs_close(fd)
    return true, nil
end

tool.handler = function(input)
    local path = input.path
    local edits = input.edits

    if type(path) ~= "string" or path == "" then
        return "Error: `path` must be a non-empty string."
    end
    if type(edits) ~= "table" or #edits == 0 then
        return "Error: `edits` must be a non-empty array."
    end

    -- Load the file.
    local original, read_err = read_all(path)
    if not original then
        return "Error: " .. (read_err or ("could not read " .. path))
    end

    -- Validate every entry first, collecting the byte-range each
    -- `before` resolves to. We need this in two passes:
    --   1. uniqueness check (count occurrences)
    --   2. overlap check (compare resolved ranges pairwise)
    local problems = {}     -- list of "edit #N: ..." strings
    local ranges = {}       -- per-edit { start_byte, end_byte } or nil

    for i, e in ipairs(edits) do
        if type(e) ~= "table" then
            problems[#problems + 1] = string.format(
                "edit #%d: entry is not an object", i
            )
            ranges[i] = nil
        elseif type(e.old) ~= "string" or type(e.new) ~= "string" then
            problems[#problems + 1] = string.format(
                "edit #%d: `old` and `new` must both be strings", i
            )
            ranges[i] = nil
        elseif e.old == "" then
            problems[#problems + 1] = string.format(
                "edit #%d: `old` is the empty string (would be ambiguous)", i
            )
            ranges[i] = nil
        else
            -- string.find with `plain = true` skips pattern parsing,
            -- so the search is literal. Count occurrences by walking.
            local count = 0
            local first_start, first_end = nil, nil
            local search_from = 1
            while true do
                local s, ee = string.find(original, e.old, search_from, true)
                if not s then break end
                count = count + 1
                if count == 1 then
                    first_start, first_end = s, ee
                end
                search_from = ee + 1
            end
            if count == 0 then
                -- Truncate the previewed snippet so the error stays
                -- legible in tool output.
                local snippet = e.old
                if #snippet > 80 then
                    snippet = snippet:sub(1, 77) .. "..."
                end
                problems[#problems + 1] = string.format(
                    "edit #%d: `old` not found in file. Snippet: %q",
                    i, snippet
                )
                ranges[i] = nil
            elseif count > 1 then
                problems[#problems + 1] = string.format(
                    "edit #%d: `old` matches %d times (need exactly 1). " ..
                        "Widen with surrounding context to disambiguate.",
                    i, count
                )
                ranges[i] = nil
            else
                ranges[i] = { first_start, first_end }
            end
        end
    end

    -- Overlap check (only meaningful if we got this far without
    -- per-edit problems; otherwise the user already has plenty to
    -- fix and overlap noise would be confusing).
    if #problems == 0 then
        for i = 1, #ranges do
            for j = i + 1, #ranges do
                local a, b = ranges[i], ranges[j]
                if a and b and not (a[2] < b[1] or b[2] < a[1]) then
                    problems[#problems + 1] = string.format(
                        "edits #%d and #%d target overlapping regions " ..
                            "(bytes %d-%d and %d-%d). Combine them into one " ..
                            "edit with a wider `old`.",
                        i, j, a[1], a[2], b[1], b[2]
                    )
                end
            end
        end
    end

    if #problems > 0 then
        return "Error: edit rejected (" .. #problems .. " issue" ..
            (#problems == 1 and "" or "s") .. "); file not modified.\n" ..
            "  - " .. table.concat(problems, "\n  - ") .. "\n"
    end

    -- Apply edits. We sort by start position ascending and rebuild
    -- the file from non-overlapping slices. This avoids the O(N*M)
    -- repeated-substring-substitution and keeps each edit's
    -- `before` matched against the original (not the in-progress
    -- result).
    local order = {}
    for i = 1, #edits do order[i] = i end
    table.sort(order, function(a, b)
        return ranges[a][1] < ranges[b][1]
    end)

    local out = {}
    local cursor = 1
    for _, idx in ipairs(order) do
        local r = ranges[idx]
        if r[1] > cursor then
            out[#out + 1] = original:sub(cursor, r[1] - 1)
        end
        out[#out + 1] = edits[idx].new
        cursor = r[2] + 1
    end
    if cursor <= #original then
        out[#out + 1] = original:sub(cursor)
    end
    local new_content = table.concat(out)

    -- Write back.
    local ok, write_err = write_all(path, new_content)
    if not ok then
        return "Error: file read OK but write failed: " ..
            tostring(write_err)
    end

    return string.format(
        "Applied %d edit%s to %s. File is now %d bytes (was %d).",
        #edits, (#edits == 1 and "" or "s"), path, #new_content, #original
    )
end

local function edit_diff(input)
    local obj = std.decode(input)
    if not obj or type(obj.edits) ~= "table" then return nil end
    local out = {}
    for _, e in ipairs(obj.edits) do
        if type(e) == "table" then
            if type(e.old) == "string" then
                for l in (e.old .. "\n"):gmatch("(.-)\n") do if l ~= "" then out[#out + 1] = "-" .. l end end
            end
            if type(e.new) == "string" then
                for l in (e.new .. "\n"):gmatch("(.-)\n") do if l ~= "" then out[#out + 1] = "+" .. l end end
            end
        end
    end
    return table.concat(out, "\n")
end

std.install_renderer(tool.name, function(st)
    local obj = std.decode(st.input)
    local n = obj and type(obj.edits) == "table" and #obj.edits or 0
    if n == 1 then return "edit " .. tostring(obj.path or "") .. " (1 edit)" end
    if n > 1 then return string.format("edit %s (%d edits)", tostring(obj.path or ""), n) end
    return "edit " .. tostring(obj and obj.path or "")
end, function(st)
    return edit_diff(st.input) or st.output
end)

return tool