From 059d44027018f1eaa69d3a0f9779da78eb651ced Mon Sep 17 00:00:00 2001 From: tjpcc Date: Tue, 10 Oct 2023 18:30:22 -0600 Subject: identify and error on conflicting servertls directives on merged gemini servers fixes #7 --- parse.go | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'parse.go') diff --git a/parse.go b/parse.go index 15c5877..886aa2d 100644 --- a/parse.go +++ b/parse.go @@ -241,7 +241,10 @@ func parseServerDirectives(server *Server, buf *bufio.Reader) error { case "host": server.Hostnames = append(server.Hostnames, parseHost(rest)...) case "servertls": - server.TLS, err = parseServerTLS(rest) + if server.TLS != nil { + return fmt.Errorf("duplicate servertls directives in %s server", server.Type) + } + server.tlsCertFile, server.tlsKeyFile, server.TLS, err = parseServerTLS(rest) if err != nil { return err } @@ -302,20 +305,21 @@ func validateRoute(serverType string, dir *RouteDirective) error { return nil } -func parseServerTLS(text string) (*tls.Config, error) { +func parseServerTLS(text string) (string, string, *tls.Config, error) { spl := strings.Split(text, " ") if len(spl) != 4 { - return nil, errors.New("invalid 'servertls' directive") + return "", "", nil, errors.New("invalid 'servertls' directive") } if spl[0] == "cert" { spl[0], spl[1], spl[2], spl[3] = spl[2], spl[3], spl[0], spl[1] } if spl[0] != "key" || spl[2] != "cert" { - return nil, errors.New("invalid 'servertls' directive") + return "", "", nil, errors.New("invalid 'servertls' directive") } - return gemini.FileTLS(spl[3], spl[1]) + conf, err := gemini.FileTLS(spl[3], spl[1]) + return spl[3], spl[1], conf, err } func parseHost(text string) []string { -- cgit v1.2.3